[Spice-devel] [PATCH spice 1/9] build-sys: disable static lib by default

Christophe Fergeau cfergeau at redhat.com
Fri Dec 11 05:30:11 PST 2015


On Thu, Dec 10, 2015 at 02:40:52PM -0500, Frediano Ziglio wrote:
> > 
> > From: Marc-André Lureau <mlureau at redhat.com>
> > 
> > It's not used in general, so no need to build it by default.
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> > ---
> >  configure.ac | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 907a275..2eb8128 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -43,7 +43,7 @@ if test x"$ac_cv_prog_cc_c99" = xno; then
> >  fi
> >  AC_PROG_INSTALL
> >  AC_CANONICAL_HOST
> > -AC_PROG_LIBTOOL
> > +LT_INIT([disable-static])
> >  AM_PROG_CC_C_O
> >  AC_C_BIGENDIAN
> >  AC_PATH_PROGS(PYTHON, python2 python)
> > --
> > 2.5.0
> 
> I tested and you can always turned on the compilation adding an
> additional option so I agree.
> 
> I also checked the SPECs files we provide and we don't pack static
> library files.
> 
> Acked-by: Frediano Ziglio <fziglio at redhat.com>
> 
> I won't merge, I'll wait other possible comments.

Yup, works for me.

Christophe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151211/070aebda/attachment.sig>


More information about the Spice-devel mailing list