[Spice-devel] [PATCH spice 8/9] red-channel: return number of created pipe items

[Christophe Fergeau]

On Thu, Dec 10, 2015 at 01:04:28AM +0100, Marc-André Lureau wrote:
> This is useful in the following patches to count the number of replies
> to wait for.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> ---
>  server/red-channel.c | 21 +++++++++++++--------
>  server/red-channel.h |  2 +-
>  2 files changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/server/red-channel.c b/server/red-channel.c
> index fcbe868..ff1411f 100644
> --- a/server/red-channel.c
> +++ b/server/red-channel.c
> @@ -2233,14 +2233,14 @@ int red_client_during_migrate_at_target(RedClient *client)
>  typedef void (*rcc_item_t)(RedChannelClient *rcc, PipeItem *item);
>  typedef int (*rcc_item_cond_t)(RedChannelClient *rcc, PipeItem *item);
>  
> -static void red_channel_pipes_create_batch(RedChannel *channel,
> -                                new_pipe_item_t creator, void *data,
> -                                rcc_item_t callback)
> +static int red_channel_pipes_create_batch(RedChannel *channel,
> +                                          new_pipe_item_t creator, void *data,
> +                                          rcc_item_t callback)

It seems like this can never get negative, so maybe size_t? (or
unsigned int)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151211/264308b9/attachment.sig>