[Spice-devel] [PATCH 1/5] tests: allocate memory in a coherent fashion

Christophe Fergeau cfergeau at redhat.com
Tue Dec 15 09:46:42 PST 2015


On Tue, Dec 15, 2015 at 12:15:09PM +0000, Frediano Ziglio wrote:
> Do not free memory allocated with C functions (like calloc) using g_free;
> although this is possible with default Glib allocator this is not safe.
> Also use consistent allocation functions. All other spice-server code
> does not use Glib allocations so for coherence do not use them for
> watches.

In my opinion, we should aim at deprecating spice_malloc & friends and
use glib allocation functions instead. With that in mind, in situations
such as this one, I would have kept the preexisting g_free and used
g_new0.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151215/21886156/attachment.sig>


More information about the Spice-devel mailing list