[Spice-devel] [PATCH 1/5] tests: allocate memory in a coherent fashion

[Victor Toso]

Hi,

On Tue, Dec 15, 2015 at 06:46:42PM +0100, Christophe Fergeau wrote:
> On Tue, Dec 15, 2015 at 12:15:09PM +0000, Frediano Ziglio wrote:
> > Do not free memory allocated with C functions (like calloc) using g_free;
> > although this is possible with default Glib allocator this is not safe.
> > Also use consistent allocation functions. All other spice-server code
> > does not use Glib allocations so for coherence do not use them for
> > watches.

> In my opinion, we should aim at deprecating spice_malloc & friends and
> use glib allocation functions instead. With that in mind, in situations
> such as this one, I would have kept the preexisting g_free and used
> g_new0.
>
> Christophe

This is my preference as well also for the g_return_* discussion but as
there are a few people against it at this time due the merge, it makes
sense to postpone it.

So, at this time, all spice_ functions are preferred against glib ones.
  Victor Toso