[Spice-devel] [PATCH 8/9] worker: make sure we dispatch after releasing items

[Frediano Ziglio]

> 
> Hi
> 
> ----- Original Message -----
> > 
> > Then with a
> > 
> > $ cat stderr_from_replay | grep 'release on ' | sort | uniq -c
> >       3 release on dispatch
> >     502 release on display
> >    3249 release on push
> >    1843 release on watch
> > 
> > So mostly of the times items are released pushing (which is expected) but
> > also on watches (so data from file descriptors) and processing display
> > data.
> > I think this patch address the items during watches which before happened
> > always before the push.
> > 
> > I think a better solution is to move red_push inside worker_source_prepare.
> 
> prepare() is called before entering poll(), you shouldn't do heavy work
> there.
> 

Any other idea to fix these issues without forcing extra loop execution?

Frediano