[Spice-devel] [PATCH spice 12/18] Declare AsyncCommand in red-common

[Christophe Fergeau]

On Wed, Dec 16, 2015 at 07:54:07AM -0500, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > 
> > > > > This is the simplest way I could find to have a AsyncCommand in
> > > > > QXLState in following patch.
> > > > > 
> > > > 
> > > > The following patch just update spice-common repository.
> > > > This patch is referring the "following"?
> > > > 
> > > > The reasoning looks a bit weak to me.
> > > 
> > > Why? I just wanted to store the current gl-draw AsyncCommand in QXLState.
> > > 
> > 
> > You can just use
> > 
> > struct AsyncCommand *aync_command;
> > 
> > like for dispatcher
> 
> Correct, that seems to be a common practice in Spice server code. I'll
> change the series to use that instead then. However, it would be nice
> to consider having the common typedefs in common imho. It doesn't make
> sense to me that in some header you can use "Foo" type directly and
> some you don't and have to use "struct Foo".

Yup, agreed.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151216/99f10862/attachment.sig>