[Spice-devel] [spice-common v3 6/7] log: Kill spice_warn_if

Victor Toso lists at victortoso.com
Wed Dec 16 06:09:00 PST 2015


Hi,

On Wed, Dec 16, 2015 at 02:27:12PM +0100, Christophe Fergeau wrote:
> It's redundant with spice_warn_if_fail(), and can even be confusing.
> 
> Acked-by: Jonathon Jongsma <jjongsma at redhat.com>
Acked-by: Victor Toso <victortoso at redhat.com>
> ---
>  common/log.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/common/log.h b/common/log.h
> index a56105a..0e03f59 100644
> --- a/common/log.h
> +++ b/common/log.h
> @@ -95,12 +95,6 @@ void spice_log(const char *log_domain,
>      }                                                   \
>  } G_STMT_END
>  
> -#define spice_warn_if(x) G_STMT_START {                 \
> -    if G_UNLIKELY(x) {                                  \
> -        spice_warning("condition `%s' reached", #x);    \
> -    }                                                   \
> -} G_STMT_END
> -
>  #define spice_assert(x) G_STMT_START {                  \
>      if G_LIKELY(x) { } else {                           \
>          spice_error("assertion `%s' failed", #x);       \
> -- 
> 2.5.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


More information about the Spice-devel mailing list