[Spice-devel] [spice-server PATCH] display-channel: Don't disconnect when lz4 not supported

[Lukas Venhoda]

Hi Pavel,

On Wed, Dec 16, 2015 at 3:01 PM, Pavel Grunt <pgrunt at redhat.com> wrote:

> Hi Lukas,
>
> is the client disconnected?
>

If the function that handles preferred compression returns FALSE,
red_channel_client_disconnect() is called.


>
> On Wed, 2015-12-16 at 14:48 +0100, Lukas Venhoda wrote:
> > Don't diconnect client, if lz4 is requested as a preferred
> typo     ^
> > compression,
> > but the server doesn't support it.
>
> Please add the reference to the bug
>
> > ---
> > Sidenote:
> > Should server disconnect, when unsupported compression is requested?
> > FE if client sends unknown compression, and this switch goes to
> > default.
> > Default could always return TRUE, just not set the compression.
> I agree with you, in this case (it is just a preferred compression) it
> make sense to return TRUE.
>
> Pavel <http://lists.freedesktop.org/mailman/listinfo/spice-devel>
>

I'll add reference, fix the typo and change default in the switch
statement, to return TRUE, that should be a better fix.

-- 
Lukas Venhoda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151216/4c89dc2f/attachment.html>