[Spice-devel] [spice-server PATCH v2] dcc: Don't disconnect channel, when compression is not supported

[Lukas Venhoda]

Don't disconnect the display channel, when unsupported compression is
requested from the client. Not changing the compression is enough.

https://bugs.freedesktop.org/show_bug.cgi?id=92821
---
Forgot to add bug reference

Changes since v1:
 - Not only for lz4, but now for all unsupported compressions
---
 server/dcc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/server/dcc.c b/server/dcc.c
index b2ee7a6..3135733 100644
--- a/server/dcc.c
+++ b/server/dcc.c
@@ -1361,11 +1361,10 @@ static int dcc_handle_preferred_compression(DisplayChannelClient *dcc,
     case SPICE_IMAGE_COMPRESSION_GLZ:
     case SPICE_IMAGE_COMPRESSION_OFF:
         dcc->image_compression = pc->image_compression;
-        return TRUE;
     default:
         spice_warning("preferred-compression: unsupported image compression setting");
-        return FALSE;
     }
+    return TRUE;
 }

 int dcc_handle_message(RedChannelClient *rcc, uint32_t size, uint16_t type, void *msg)
--
2.5.0