[Spice-devel] [PATCH] audio: use GstVolume to have volume control.

[Marc-André Lureau]

Hi

nack to the patch:

----- Original Message -----
> I would like to know if the following patch is acceptable or should I try to
> have a
> patch in directsoundsrc using the mixer api is a better approach.

As long as the mixer API is to control the application stream volume, this is the right approach.

The point of controling the application stream volume, instead of having a gst volume element, is exactly to avoid this kind of problems you mentionned of multiplicity of volume controls, and user complaining that even if the guest volume is to the maximum, no sound can be heard.