[Spice-devel] [PATCH spice-gtk] Fix: remove dependency cycle

Christophe Fergeau cfergeau at redhat.com
Mon Feb 16 01:34:17 PST 2015


Hey,

On Wed, Feb 11, 2015 at 03:34:13PM +0100, Javier Celaya wrote:
> channel-port.h includes spice-client.h, that includes channel-webdav.h,
> that includes channel-port.h again. It's enough if channel-port.h
> includes spice-channel.h

Is it causing actual issues? Most channel-*.h files include
spice-client.h, which in turn includes channel-*.h again.

Christophe

> ---
>  gtk/channel-port.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gtk/channel-port.h b/gtk/channel-port.h
> index 84d512d..08c15dc 100644
> --- a/gtk/channel-port.h
> +++ b/gtk/channel-port.h
> @@ -19,7 +19,7 @@
>  #define __SPICE_CLIENT_PORT_CHANNEL_H__
>  
>  #include <gio/gio.h>
> -#include "spice-client.h"
> +#include "spice-channel.h"
>  
>  G_BEGIN_DECLS
>  
> -- 
> 1.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150216/6f5897dc/attachment.sig>


More information about the Spice-devel mailing list