[Spice-devel] [PATCH spice-gtk 10/9] session: Set SpiceSession::playback_channel to NULL when it's destroyed

[Marc-André Lureau]

----- Original Message -----
> This fixes a runtime warning during migration:
> 
> (remote-viewer:5884): GSpice-WARNING **: (spice-session.c:2144):
> spice_session_channel_new: runtime check failed: (s->playback_channel ==
> NULL)
> ---
> I need that patch on top of that series to fix a runtime warning during
> migration.

Do you mean switch-host? (channels shouldn't be removed or replaces on semi/seamless migration)

ack (that should have been there when it was introduced)

> 
> Christophe
> 
> 
>  gtk/spice-session.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> index 32f466c..b4cb1bd 100644
> --- a/gtk/spice-session.c
> +++ b/gtk/spice-session.c
> @@ -2171,6 +2171,8 @@ static void spice_session_channel_destroy(SpiceSession
> *session, SpiceChannel *c
>      if (channel == s->cmain) {
>          CHANNEL_DEBUG(channel, "the session lost the main channel");
>          s->cmain = NULL;
> +    } else if (channel == SPICE_CHANNEL(s->playback_channel)) {
> +        s->playback_channel = NULL;
>      }
>  
>      ring_remove(&item->link);
> --
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>