[Spice-devel] [PATCH spice-gtk 3/5] webdav: use a pipe to connect to server

[Marc-André Lureau]

On Mon, Feb 23, 2015 at 3:57 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> Is it required to pass this fake 127.0.0.1 address?
> soup_server_accept_iostream says it can accept NULL local/remote
> addresses.

It depends how you use the server. If you accept http 1.0 requests
(right now phodav doesn't prevent that), in some conditions, this will
fail and trigger a warning. So it is best to give a local address

>> +    if (!soup_server_accept_iostream(server, peer, addr, addr, &error))
>> +        goto fail;
>
> Looks good otherwise from a cursory look (iow trusting that it has been
> tested and works ok).




-- 
Marc-André Lureau