[Spice-devel] [PATCH spice-gtk 1/5] Add GIOStream-based pipe

Christophe Fergeau cfergeau at redhat.com
Mon Feb 23 07:28:07 PST 2015


On Mon, Feb 23, 2015 at 10:09:49AM -0500, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > > Because that field is for peer closing. I can rename it peer_closed
> > > perhaps? (peer->peer_closed...)
> > 
> > You lost me here. Do you mean PipeInputStream::closed means that the
> > peer PipeOutputStream has been closed? If that's what you mean, then it
> > definitely should be peer_closed.
> 
> I don't mind, for me the field means the pipe is closing, either side.
> However, since it's internal to the pipe implementation and is only
> set by the peer, I guess it could be closed peer_closed too. That
> really doesn't change much of the meaning of this code anyway.

pipe_closed then if that variable does not specifically refer to either
side of the pipe being closed ?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150223/c162665b/attachment.sig>


More information about the Spice-devel mailing list