[Spice-devel] [PATCH][server] Do not compress bitmaps on UNIX socket

[Marc-André Lureau]

Hi

----- Original Message -----
> On UNIX socket do not perform unnecessary image compression
> ---
>  server/red_worker.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/server/red_worker.c b/server/red_worker.c
> index 58cc827..5deb30b 100644
> --- a/server/red_worker.c
> +++ b/server/red_worker.c
> @@ -6811,7 +6811,8 @@ static FillBitsType fill_bits(DisplayChannelClient
> *dcc, SpiceMarshaller *m,
>          /* Images must be added to the cache only after they are compressed
>             in order to prevent starvation in the client between pixmap_cache
>             and
>             global dictionary (in cases of multiple monitors) */
> -        if (!red_compress_image(dcc, &image, &simage->u.bitmap,
> +        if (reds_stream_get_family(rcc->stream) == AF_UNIX ||
> +            !red_compress_image(dcc, &image, &simage->u.bitmap,
>                                  drawable, can_lossy, &comp_send_data)) {
>              SpicePalette *palette;

Assuming this has been tested, it looks fine to me.