[Spice-devel] [PATCH spice-html5 v3 0/7] Enable file transfer from client to guest

[Jeremy White]

On 01/14/2015 10:44 AM, Pavel Grunt wrote:
> Hi, the intetion of this series is to add the ability to transfer files from the client to the guest.

Hi Pavel,

This looks (mostly) good to me.  I'm really troubled by the 2K limit,
and the 5 token window size; that makes transfers painfully slow.  That
is arguably outside the scope of this patch set, though.

I did find one issue: in handling SPICE_MSG_MAIN_INIT in main.js, you
need to set the number of agent_tokens first thing.  Otherwise, the
connect_agent() call tries to send a monitor config that doesn't go out
right away.

I'm happy to ACK and push these and then fix that, or you can send a
revision; your choice.

More broadly, I would ask a further favor, though:  we should file a bug
or somehow make sure we have recorded some of the less that ideal
behaviors in Spice's file transfer stuff:
  * 2K limit
  * no progress dialog
  * file truncated to max size

So they don't get lost.

Cheers,

Jeremy