[Spice-devel] [PATCH spice-html5 v3 0/7] Enable file transfer from client to guest

[Jeremy White]

>>   * 2K limit
> 
> I believe the problem is somewhere else as it is working with spice-gtk. 
> The limit is checked in spice-server:
>  http://cgit.freedesktop.org/spice/spice/tree/server/agent-msg-filter.c#n43

Hmm.  You are right; the performance hit is barely noticeable in
spice-gtk; files transfer at reasonable speeds.  Sending a file in 2K
chunks, with acks every 5 chunks, is not what I would consider a good
file streaming protocol, so I assumed that I'd be able to compare
spice-gtk to scp unfavorably.  But I'm wrong on that point.

It is vastly worse in the spice-html5 client; on the order of 50x
slower.  It may be worth a progress bar and some profiling, but that can
follow these patches; their behavior seems correct to me.

> 
> Thanks a lot for the review,

Thanks for the patch set; consider it ACKed, and I've pushed it.

Cheers,

Jeremy