[Spice-devel] [PATCH spice-html5] Inform agent about client's capabilities

Jeremy White jwhite at codeweavers.com
Thu Jan 15 08:07:42 PST 2015


Hi Pavel,

Mostly looks good; one question:

On 01/15/2015 06:33 AM, Pavel Grunt wrote:
> The client should inform the agent about capabilities
> when the connection is established. This avoid receiving unhandled
> agent messages.

> +        if (agent_data.type == VD_AGENT_ANNOUNCE_CAPABILITIES)
> +        {
> +            var agent_caps = new VDAgentAnnounceCapabilities(agent_data.data);
> +            if (agent_caps.request)
> +                this.announce_agent_capabilities(0);
> +            return true;

Shouldn't we go ahead and store the inbound caps?

Cheers,

Jeremy


More information about the Spice-devel mailing list