[Spice-devel] [vdagent-win PATCH V3 11/11] g_key_get_string: use size_t for pointer difference

[Christophe Fergeau]

I don't know if VS has ptrdiff_t readily available which would
probably be the best type to use here.

Christophe


On Tue, Dec 30, 2014 at 06:20:57PM +0200, Uri Lublin wrote:
> The 64 bit Visual Studio build complains that:
>   .\file_xfer.cpp(223) : warning C4244:
>     '=' : conversion from '__int64' to 'unsigned int', possible loss of data
> ---
>  vdagent/file_xfer.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp
> index 3aad4ac..8d7c86c 100644
> --- a/vdagent/file_xfer.cpp
> +++ b/vdagent/file_xfer.cpp
> @@ -205,7 +205,7 @@ bool FileXfer::g_key_get_string(char* data, const char* group, const char* key,
>  {
>      char group_pfx[G_KEY_MAX_LEN], key_pfx[G_KEY_MAX_LEN];
>      char *group_pos, *key_pos, *next_group_pos, *start, *end;
> -    unsigned len;
> +    size_t len;
>  
>      snprintf(group_pfx, sizeof(group_pfx), "[%s]", group);
>      if (!(group_pos = strstr((char*)data, group_pfx))) return false;
> -- 
> 1.7.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150119/8c52f364/attachment.sig>