[Spice-devel] [spice-gtk] spice_parse_uri: Don't try to free unallocated string

Marc-André Lureau mlureau at redhat.com
Tue Jan 27 02:19:08 PST 2015


I guess this is to squash instead in my unix-path patch.

----- Original Message -----
> When it encounters an URI with a path, spice_parse_uri ignores it (with
> a runtime warning). However, it does not strdup the path component, so
> it's wrong to try to free it in the end/fail blocks.
> ---
>  gtk/spice-session.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/gtk/spice-session.c b/gtk/spice-session.c
> index 2dec8c7..3b86e80 100644
> --- a/gtk/spice-session.c
> +++ b/gtk/spice-session.c
> @@ -523,7 +523,6 @@ end:
>  fail:
>      g_free(uri);
>      g_free(unescaped_path);
> -    g_free(path);
>      g_free(host);
>      g_free(port);
>      g_free(tls_port);
> --
> 2.1.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 


More information about the Spice-devel mailing list