[Spice-devel] [PATCH spice-gtk 1/9] channel: delay event report to after coroutine exit

[Christophe Fergeau]

On Mon, Jan 26, 2015 at 06:39:59PM +0100, Marc-André Lureau wrote:
> On Mon, Jan 26, 2015 at 6:16 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > Is this hunk strictly needed ? The code flow when the error was emitted
> > before exiting was not different, and I expect the old code needed to go
> > through there before the coroutine exited ?
> 
> 
> c->event must be NONE: it should not attempt to reconnect on TLS when
> there is an error to report.

My understanding was that before these changes, when
g_coroutine_signal_emit was used to emit an error, this part of the code
relied on c->state != SPICE_CHANNEL_STATE_RECONNECTING to avoid calling
channel_connect(). Is this assertion now wrong after your changes?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150127/ce00495c/attachment-0001.sig>