[Spice-devel] [PATCH 2/6] LZ4: Implement ntohl to remove dependency on arpa/inet.h

[Javier Celaya]

El Lunes, 26 de enero de 2015 17:00:04 Javier Celaya escribió:
> El Lunes, 26 de enero de 2015 15:55:18 Daniel P. Berrange escribió:
> > On Mon, Jan 26, 2015 at 04:53:31PM +0100, Christophe Fergeau wrote:
> > > On Mon, Jan 26, 2015 at 09:23:58AM +0100, Javier Celaya wrote:
> > > > I saw some comments about MSVC in spice-gtk, and I thought someone
> > > > could
> > > > be
> > > > using it to build the Windows client. Anyway, I don't mind using one
> > > > solution or another, so you tell me.
> > > 
> > > spice-common may be referencing MSVC++ as the old spice-client used to
> > > be built with MSVC++, but this client is gone nowadays. As far as I
> > > know, spice-gtk for Windows is always built with mingw.
> > 
> > Yep, for the virt-viewer  Windows installer I always build from the
> > Fedora mingw toolchain + packages. So from that angle we don't care
> > about MSVC++
> 
> Ok, I'll stick with htonl/ntohl then.

Well, I just found arpa/inet.h does not exist in mingw, because socket-related 
functions are defined in winsock.h. I'll send a patch to include it.

> 
> > Regards,
> > Daniel