[Spice-devel] [PATCH xf86-qxl] Remove image cache

[Dave Airlie]

On 29 January 2015 at 23:16, Marc-André Lureau
<marcandre.lureau at gmail.com> wrote:
> I forgot that line:
>
> --- a/src/qxl_driver.c
> +++ b/src/qxl_driver.c
> @@ -854,7 +854,6 @@ qxl_enter_vt (VT_FUNC_ARGS_DECL)
>      if (qxl->mem)
>      {
>         qxl_mem_free_all (qxl->mem);
> -       qxl_drop_image_cache (qxl);
>
> On Thu, Jan 29, 2015 at 2:14 PM, Marc-André Lureau
> <marcandre.lureau at redhat.com> wrote:
>> While looking for leaks, I realized that the image cache looks
>> quite suspicious.
>>
>> Not only it leaks when qxl_drop_image_cache() is called,
>> since all the allocated image_info_t references are lost.
>> But it is also useless...
>>
>> (note: this won't help all the bug reports about vram memory "leak", or
>> rather "failed allocation", since it's a different memory area)

Yes please,

Reviewed-by: Dave Airlie <airlied at redhat.com>