[Spice-devel] [PATCH xf86-qxl] Remove image cache

[Christophe Fergeau]

On Fri, Jan 30, 2015 at 04:20:43PM +0100, Marc-André Lureau wrote:
> 
> I am not familiar with this code, I didn't write most of it. But I can
> read code and see when things are useless. If you pay a few minutes
> reading,

The point of having an explanation in the log is to save these few
minutes of people reading and guessing....
It seems this can be summed up as "The name implies it's a cache of some
sort, but data is only added to it. The only time data is looked up in
that cache is when it needs to be destroyed, and this is not done
correctly and causes leaks. Since the cached data is never used and
since it's leaky, it's better to remove it altogether".
Better than having a cryptic log message requiring the use of git show
every time someone wonders what 'useless' really means.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150130/ea2385eb/attachment-0001.sig>