[Spice-devel] [PATCH spice-protocol v2 1/2] Update enums.h for preferred compression message

[Christophe Fergeau]

Hey,

On Mon, Jun 01, 2015 at 04:47:12PM +0200, Javier Celaya wrote:
> ---
>  spice/enums.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/spice/enums.h b/spice/enums.h
> index 18e2f74..6a0ab0b 100644
> --- a/spice/enums.h
> +++ b/spice/enums.h
> @@ -181,6 +181,19 @@ typedef enum SpiceImageType {
>      SPICE_IMAGE_TYPE_ENUM_END
>  } SpiceImageType;
>  
> +typedef enum SpiceImageCompress {
> +    SPICE_IMAGE_COMPRESS_INVALID,
> +    SPICE_IMAGE_COMPRESS_OFF,
> +    SPICE_IMAGE_COMPRESS_AUTO_GLZ,
> +    SPICE_IMAGE_COMPRESS_AUTO_LZ,
> +    SPICE_IMAGE_COMPRESS_QUIC,
> +    SPICE_IMAGE_COMPRESS_GLZ,
> +    SPICE_IMAGE_COMPRESS_LZ,
> +    SPICE_IMAGE_COMPRESS_LZ4,
> +
> +    SPICE_IMAGE_COMPRESS_ENUM_END
> +} SpiceImageCompress;
> +

This turns out to be wrong as someone trying to use an older
spice-server with a newer spice-protocol will get these enum values
twice resulting in build errors :(

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150703/de51e3c4/attachment.sig>