[Spice-devel] [PATCH 1/4] Don't enable channels in channel_new

Jonathon Jongsma jjongsma at redhat.com
Thu Jul 16 14:53:57 PDT 2015


Virt-viewer creates displays for all potential displays, including ones
that are currently disabled. So it's incorrect to automatically set the
display to enabled in this function. For some reason this doesn't cause
disabled displays to accidentally become enabled, presumably only
because the displays don't have any dimensions set. But it does cause a
lot of unnecessary calls to update_display_timer() which sends down new
monitor configurations to the server.
---
 src/spice-widget.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/spice-widget.c b/src/spice-widget.c
index 59f9792..5571601 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -2434,7 +2434,6 @@ static void channel_new(SpiceSession *s, SpiceChannel *channel, gpointer data)
             mark(display, primary.marked);
         }
         spice_channel_connect(channel);
-        spice_main_set_display_enabled(d->main, get_display_id(display), TRUE);
         return;
     }
 
-- 
2.1.0



More information about the Spice-devel mailing list