[Spice-devel] [libvirt] [PATCH v4] qemu: Use heads parameter for QXL driver

[Martin Kletzander]

On Fri, Jul 17, 2015 at 06:02:25PM +0200, Christophe Fergeau wrote:
>On Fri, Jul 17, 2015 at 03:42:36PM +0200, Martin Kletzander wrote:
>> On Fri, Jul 17, 2015 at 12:11:55PM +0200, Peter Krempa wrote:
>> >On Fri, Jul 17, 2015 at 09:29:44 +0100, Frediano Ziglio wrote:
>> >>Allows to specify maximum number of head to QXL driver.
>> >>
>> >>Actually can be a compatiblity problem as heads in the XML configuration
>> >>was set by default to '1'.
>> >>
>> >>Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
>> >>---
>> >> src/qemu/qemu_capabilities.c                       |  2 ++
>> >> src/qemu/qemu_capabilities.h                       |  1 +
>> >> src/qemu/qemu_command.c                            |  5 ++++
>> >> .../qemuxml2argv-video-qxl-device-max-outputs.args |  7 ++++++
>> >> .../qemuxml2argv-video-qxl-device-max-outputs.xml  | 29 ++++++++++++++++++++++
>> >> tests/qemuxml2argvtest.c                           |  3 +++
>> >> 6 files changed, 47 insertions(+)
>> >> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-device-max-outputs.args
>> >> create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-device-max-outputs.xml
>> >>
>> >>Changes from v4:
>> >>- rebased on new master;
>> >>- add test case to qemuxml2argvtest.
>> >
>> >Note review: This was added in qemu commit
>> >http://git.qemu.org/?p=qemu.git;a=commitdiff;h=567161fdd47aeb6987e700702f6bbfef04ae0236
>> >
>> >The commit hints that you need at least spice 0.12.6. I'll update spice
>> >and test this later.
>>
>> I failed to update qemu without updating spice as well, so I'd say
>> it is safe to assume that if qemu supports it, spice will too.  And we
>> don't check all the lib versions for qemu runtime, that'd be a waste
>> of time, so this is quite alright, I think.
>>
>> I updated everything spice-related and I still can't properly build
>> qemu particularly because of the patch you mentioned.  And I update
>> everything from git.  Then I looked there and I see no such function,
>> no wonder the build fails with undefined reference to
>> spice_qxl_set_monitors_config_limit.  Although that would mean that it
>
>qemu tries to call spice_qxl_set_monitors_config_limit but the entry
>point ended up being called spice_qxl_set_max_monitors in spice-server
>:-/
>

I spend all morning fixing this to be installed properly in the
system.  Anyway, I finally managed to make this work and found out the
guest I used for it is not ready to have multiple monitors.  Anyway,
looking at everything else this definitely works, so ACK, I'll push it
in a while.

In the meantime, is the only thing this does limiting the maximum?  Is
it there just to save some memory or why?  Because otherwise I can't
see the use-case in that.  I'm not saying there isn't one, just that I
can't find it.  And I even looked under the fridge :)

Have a nice day,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150720/1bd1a060/attachment.sig>