[Spice-devel] [PATCH v4] usbredir: fix redirection of user-accesible device nodes.

[Christophe Fergeau]

Hi,

On Mon, Jul 20, 2015 at 05:46:41PM +0200, Hans de Goede wrote:
> On 20-07-15 11:51, Christophe Fergeau wrote:
> >Looks good te me now.
> >Hans, would you mind taking a quick look at that
> >patch in case you have objections on the change (if
> >spice_usb_acl_helper_open_acl_finish() fails, try to directly open the
> >device node anyway as it may be user-accessible).
> 
> I do not think that this is the right thing todo, this means e.g.
> that if policykit / the admin explicitly denies redirection, but
> the usb device node happens to be opened up (which happens with
> e.g. scanners), then we will still redirect, this seems wrong to me.

Yes, I thought a little bit about that, but achieving that does not seem
to be done on purpose by
http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=63c8526c699692b6fdca15db8209730fca7eb817
(which introduced Michal's issues). Which is why I preferred to check
with you what was the intended design ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150720/32537d69/attachment.sig>