[Spice-devel] [PATCH v3 28/51] show primitive as primitive

[Frediano Ziglio]

> On Tue, Jul 21, 2015 at 05:45:58PM +0100, Frediano Ziglio wrote:
> > ---
> >  python_modules/dissector.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/python_modules/dissector.py b/python_modules/dissector.py
> > index 413aca4..a7add96 100644
> > --- a/python_modules/dissector.py
> > +++ b/python_modules/dissector.py
> > @@ -223,7 +223,7 @@ def write_wireshark_field(writer, container, member, t,
> > tree, size, encoding='EN
> >      f_type = 'FT_NONE'
> >      base = 'BASE_NONE'
> >      vals = 'NULL'
> > -    if encoding == 'ENC_LITTLE_ENDIAN':
> > +    if t.is_primitive():
> >          assert(t.is_primitive())
> >          base = 'BASE_DEC'
> >          f_type = get_primitive_ft_type(t)
> 
> This looks like this was added in the commit right before it, any reason
> for having that in a separate commit?
> 
> Christophe
> 

Yes, well spotted, was intended to be folded as you can see from the short commit message

Frediano