[Spice-devel] [PATCH v3 16/51] Allows to specify some new attributes for wireshark

[Christophe Fergeau]

On Thu, Jul 23, 2015 at 11:15:14AM -0400, Frediano Ziglio wrote:
> > On Thu, Jul 23, 2015 at 10:49:58AM -0400, Frediano Ziglio wrote:
> > > > 
> > > > On Tue, Jul 21, 2015 at 05:45:46PM +0100, Frediano Ziglio wrote:
> > > > > To make output more useful fields from the protocol should have
> > > > > additional information like description, name, type and so on.
> > > > > 
> > > > > List of attributes added:
> > > > > - ws_desc, just a simple description
> > > > > - ws_name name of the field. See below
> > > > 
> > > > This attribute does not seem to be used
> > > >
> > > 
> > > Hard to spot but is used :-)
> > 
> > In spice.proto? 'git grep ws_name' turns up empty at least.
> > 
> > Christophe
> > 
> 
> Actually even from test.proto, I should consider adding to it (it's
> one reason I have a separate .proto file).
> For instance can be used in enumerators to specify just the name as
> the description is based on enumerator name.

I understand what it can be used for, but I don't know if it's useful to
add something that is not used currently in actual .proto files. This is
kind of similar to the ptr32 support you removed imo.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150723/ae2e0f33/attachment.sig>