[Spice-devel] [spice-gtk PATCH] Handle single headed monitors that have a non-zero x, y config

[Fabiano Fidêncio]

On Tue, Jul 28, 2015 at 8:53 PM, Pavel Grunt <pgrunt at redhat.com> wrote:
> On Tue, 2015-07-21 at 22:43 +0200, Victor Toso wrote:
>> Hi,
>>
>> On Mon, Jul 20, 2015 at 06:35:28PM -0400, Sandy Stutsman wrote:
>> > Hi Again.
>> > > > > > > > diff --git a/src/spice-widget.c b/src/spice-widget.c
>> > > > > > > > index 59f9792..3ec2e65 100644
>> > > > > > > > --- a/src/spice-widget.c
>> > > > > > > > +++ b/src/spice-widget.c
>> > > > > > > > @@ -293,7 +293,12 @@ static void
>> > > > > > > > update_monitor_area(SpiceDisplay
>> > > > > > > > *display)
>> > > > > > > >          goto whole;
>> > > > > > > >      }
>> > > > > > > >
>> > > > > > > > -    update_area(display, c->x, c->y, c->width, c->height);
>> > > > > > > > +    /* If only one head on this monitor, update the whole area
>> > > > > > > > */
>> > > > > > > > +    if(monitors->len == 1) {
>> > > > > > > > +        update_area(display, 0, 0, c->width, c->height);
>> > > > > > > > +    } else {
>> > > > > > > > +        update_area(display, c->x, c->y, c->width, c->height);
>> > > > > > > > +    }
>> > I did a little more testing today.  I did see the "Waiting for display ...2"
>> > message whenever
>> > I started the remote-viewer with 1 monitor and tried to add a second.  It
>> > happened both
>> > with and without the patch.  If I added the second monitor, closed the
>> > viewer and
>> > re-opened it, the second monitor will display just fine.
>> >
>>
>> Great, so it isn't really related to this patch.
>>
>> > The good news is that when the this patch is paired with the monitor config
>> > qxl patch,
>> > https://bugzilla.redhat.com/show_bug.cgi?id=1202419, I don't see the problem
>> > at all.
>>
>> Right, this is the patch I was missing then:
>> http://cgit.freedesktop.org/spice/win32/qxl/commit/?id=ed37b635188893719c59d71
>> c031feddd01408f36
>> Do you have an qxl installer with the above patch for me to test it locally?
>>
>> I'm asking because Pavel verified a problem in the following test:
>> 1-) Connected with remove-viewer and both displays enabled
>> 2-) Disable display 1
>> 3-) Disconnect
>> 4-) Connect again
>> R: Only Display 2 is enabled and it isn't possible to enable Display 1
>>
>> If the above is also fixed with newer qxl them I don't see problems with
>> this patch as the main concern was related to Linux guest and I wasn't
>> able to find any problem...
>
> I found out that it is unrelated to this patch - sorry about the confusion.
> It is a bug in remote-viewer https://bugs.freedesktop.org/show_bug.cgi?id=91489
>
> Pavel
>>
>> Best,
>> Victor Toso
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

I've pushed the patch.
According to the discussions that happened on #spice we will probably
need a new patch on a few other components in order to avoid breaking
backward compatibility (due to the QXL patch applied, not this one).

Looking forward for the next patches and thanks for the contribution.

Best Regards,
-- 
Fabiano Fidêncio