[Spice-devel] [PATCH 5/5] usb-device-manager: Configure UsbDk hiding rules on auto-redirection

[Christophe Fergeau]

On Sun, May 31, 2015 at 12:30:56PM +0300, Dmitry Fleytman wrote:
> 
> > On May 28, 2015, at 18:48 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > 
> > On Thu, May 28, 2015 at 01:24:04PM +0300, Kirill Moizik wrote:
> >> #ifdef USE_WINUSB
> >>     use_usbdk = is_usbdk_driver_installed();
> > 
> > Any reason why line was added before rather than in this commit?
> 
> 
> Yes, this line is a part of backend selection mechanism.
> use_usbdk variable needs to be set and used by previous patches.

But the rest of the code in this commit won't work at all when
is_usbdk_driver_installed() returned TRUE, will it? I'd just set
use_usbdk to FALSE in this commit as it's just in preparation for usbdk
support, and then initialize properly to is_usbdk_driver_installed()
once the rest of the code knows how to handle usbdk.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150601/815e3c5f/attachment.sig>