[Spice-devel] [PATCH 00/11 v2] Miscellaneous stability patches
Frediano Ziglio
fziglio at redhat.com
Wed Jun 3 04:09:08 PDT 2015
This set of patches mainly contains fix for some memory issues
using quite aggressively surfaces and other minor problems like
images going black after a while.
There are no code change from v1, changes:
- fix path prefix
- rebased on drm-next branch;
- add "drm/qxl" prefix on subject;
- add reviewed by.
About which patches should be applied surely (attempting to put a priority)
- "Move main reference counter to GEM object instead of TTM ones" this can
causes memory corruption even not wanting to;
- "Avoid double free on error" this can be cause leaks in kernel if user space
wants, mitigated by the fact that usually DRM inodes are owned by root;
- "Handle all errors in qxl_surface_evict" could cause corruption too, not
really probable but taking into account that Xorg implementation use a lot
signals is not so impossible;
- "Handle correctly failures in qxl_alloc_relase_reserved", "Do not leak memory
if qxl_release_list_add fails" just cause leaks on situation where memory is
already REALLY low, can be omitted;
- "Fix print statement not using uninitialized variable", "Remove format string
errors" should just print garbage and debugging is disabled by default, not
necessary.
Frediano Ziglio (11):
drm/qxl: Do not cause spice-server to clean our objects
drm/qxl: Do not leak memory if qxl_release_list_add fails
drm/qxl: Fix print statement not using uninitialized variable
drm/qxl: Avoid double free on error
drm/qxl: Handle all errors in qxl_surface_evict
drm/qxl: Fix return for qxl_release_alloc
drm/qxl: Handle correctly failures in qxl_alloc_relase_reserved
drm/qxl: Remove format string errors
drm/qxl: Move main reference counter to GEM object instead of TTM ones
drm/qxl: Simplify cleaning qxl processing command
drm/qxl: Propagate correctly errors from qxlhw_handle_to_bo
drivers/gpu/drm/qxl/qxl_cmd.c | 11 +++++-----
drivers/gpu/drm/qxl/qxl_display.c | 2 +-
drivers/gpu/drm/qxl/qxl_drv.h | 2 +-
drivers/gpu/drm/qxl/qxl_gem.c | 10 +++++++--
drivers/gpu/drm/qxl/qxl_ioctl.c | 46 +++++++++++++++------------------------
drivers/gpu/drm/qxl/qxl_object.c | 11 ++++------
drivers/gpu/drm/qxl/qxl_release.c | 13 +++++++----
7 files changed, 46 insertions(+), 49 deletions(-)
--
2.1.0
More information about the Spice-devel
mailing list