[Spice-devel] [PATCH spice-html5 3/3] Add support for stream reports.

[Jeremy White]

Hey Christophe,

>>
>> -    if (msg.type == SPICE_MSG_DISPLAY_STREAM_DATA)
>> +    if (msg.type == SPICE_MSG_DISPLAY_STREAM_DATA ||
>> +        msg.type == SPICE_MSG_DISPLAY_STREAM_DATA_SIZED)
>>       {
>> -        var m = new SpiceMsgDisplayStreamData(msg.data);
>> +        var m;
>> +        if (msg.type == SPICE_MSG_DISPLAY_STREAM_DATA_SIZED)
>> +            m = new SpiceMsgDisplayStreamDataSized(msg.data);
>> +        else
>> +            m = new SpiceMsgDisplayStreamData(msg.data);
>> +
>
> Doesn't this belong to the previous commit?
> Same comment as 2/3, not very familiar with all of that, but looks ok.

It's refactoring the code for the purpose of the stream reports; we now 
want both messages to come through a single path, so we can call the new 
stream reports.

It's perhaps a semantic difference; the net result is the same, but in 
my mind it belongs in this patch, not the prior one.

Thanks for the review!

Cheers,

Jeremy