[Spice-devel] [PATCH] spice-widget: Do not update display when resize-guest is disabled

[Fabiano Fidêncio]

On Thu, Jun 4, 2015 at 1:23 PM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> Updating the display causes weird behaviors in virt-viewer, like
> re-resizing to a previous monitor config when, after changing the
> display resolution (through System > PReferences > Displays). the agent
> reconnects.
> It is not perfect yet, because when the agent reconnects the guest
> resizes to the previous config and switch to the proper one, but this
> seems more like an agent bug than a spice-gtk one..

Ah, just one more thing that would worth to mention, it doesn't happen
with KMS driver on F21 (newest system that I was able to test)
All my tests were made using a CentOS 6.6 as guest.

> ---
>  gtk/spice-widget.c | 4 ----
>  1 file changed, 4 d.eletions(-)
>
> diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
> index b9c4972..260fda5 100644
> --- a/gtk/spice-widget.c
> +++ b/gtk/spice-widget.c
> @@ -293,10 +293,6 @@ static void update_monitor_area(SpiceDisplay *display)
>          goto whole;
>      }
>
> -    if (!d->resize_guest_enable)
> -        spice_main_update_display(d->main, get_display_id(display),
> -                                  c->x, c->y, c->width, c->height, FALSE);
> -
>      update_area(display, c->x, c->y, c->width, c->height);
>      g_clear_pointer(&monitors, g_array_unref);
>      return;
> --
> 2.4.2
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedeskto.p.org/mailman/listinfo/spice-devel


Best Regards,
-- 
Fabiano Fidêncio