[Spice-devel] [spice-gtk PATCH 0/3] spicy: Rewrite of connect dialog

[Marc-André Lureau]

Hi


----- Original Message -----
> Connect dialog was hardcoded, and didn't have a parent window.
> 
> Changed dialog to a window, because spicy creates no window prior to creating
> the dialog. No parent can be supplied.
> 
> Moved UI definition from code to XML.
> Moved the "dialog" code to its own module.

That looks fine, ack. Please keep in mind that spicy is a test tool, it should only be maintained to keep this goal in mind. virt-viewer/remote-viewer is the spice-gtk client of choice.

> 
> Lukas Venhoda (3):
>   spicy-connect: Connect dialog changed to window
>   spicy-connect: Added new source files to Makefile
>   spicy: Removed connect dialog from spicy.c
> 
>  gtk/Makefile.am       |   2 +
>  gtk/spicy-connect.c   | 197
>  ++++++++++++++++++++++++++++++++++++++++++++++++++
>  gtk/spicy-connect.h   |  26 +++++++
>  gtk/spicy-connect.xml | 175 ++++++++++++++++++++++++++++++++++++++++++++
>  gtk/spicy.c           | 125 +-------------------------------
>  5 files changed, 402 insertions(+), 123 deletions(-)
>  create mode 100644 gtk/spicy-connect.c
>  create mode 100644 gtk/spicy-connect.h
>  create mode 100644 gtk/spicy-connect.xml
> 
> --
> 2.4.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>