[Spice-devel] [spice-gtk PATCH 1/3] spicy-connect: Connect dialog changed to window

[Christophe Fergeau]

On Mon, Jun 08, 2015 at 11:36:36AM +0200, Lukas Venhoda wrote:
> Connect dialog in spicy had no transinient parent.
> It didn't make much sense for it to be a dialog.
> 
> Changed the dialog to window.
> Moved UI definition from code to XML.
> Moved dialog to its own module.
> ---
>  gtk/spicy-connect.c   | 197 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  gtk/spicy-connect.h   |  26 +++++++
>  gtk/spicy-connect.xml | 175 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 398 insertions(+)
>  create mode 100644 gtk/spicy-connect.c
>  create mode 100644 gtk/spicy-connect.h
>  create mode 100644 gtk/spicy-connect.xml

You don't seem to be adding this .xml file to Makefile.am, you need to
make sure it gets installed, and that it's shipped in tarballs. You can
check how virt-viewer deals with it's src/*.xml files.

You probably also need to be more careful to the path to the .xml file
you give to gtk_builder_add_from_file() (side-note, _new_from_file()
would be fine too). Currently, I think it will fail if you try to run
an installed version of spicy, or even if you try to run ./gtk/spicy.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150608/87b3b8f1/attachment.sig>