[Spice-devel] master build for windows

[Victor Toso]

Hey,

On Tue, Jun 09, 2015 at 09:54:37AM +0200, Christophe Fergeau wrote:
> On Mon, Jun 08, 2015 at 08:50:27PM +0200, Fabiano Fidêncio wrote:
> > On Mon, Jun 8, 2015 at 8:10 PM, Kirill Moizik <kirill at daynix.com> wrote:
> > > Hi,
> > >  I can't build spice-gtk for windows, i got next error:
> > >
> > > channel-webdav.c: In function 'demux_to_client_cb':
> > >
> > > channel-webdav.c:321:5: error: implicit declaration of function
> > > 'g_output_stream_write_all_finish' [-Werror=implicit-function-declaration]
> > >
> > >
> > > It seem the cause of this problem is this commit
> > > 33d4016228798108250b0ef9173f2c4c719a5065
> > >
> > >
> > > There was a switch between g_output_stream_write_async to
> > > g_output_stream_write_all_async
> > >
> > >
> > > I tried to update all mingw-glib packages, but it didn't help.
> > >
> > > What should i do to build spice-gtk for windows?
> >
> > You're missing a mingw{32,64}-glib2 package >= 2.44, as the
> > g_output_stream_write_all_async() was introduced in glib-2.44
>
> We'll probably need a fallback for older glib versions then, either
> something in glib-compat.[ch] using a thread and
> g_output_stream_write_all(), or some kind of loop with
> g_output_stream_write_async() to replace the switch to
> _write_all_async().
>
> Christophe

True, sorry about that Kirill.
I'll provide a patch compatible with older versions.

Best,
Victor Toso