[Spice-devel] [PATCH] spice-widget: Do not update display when resize-guest is disabled

[Fabiano Fidencio]

----- Original Message -----
> From: "Pavel Grunt" <pgrunt at redhat.com>
> To: "Fabiano Fidêncio" <fidencio at redhat.com>, spice-devel at freedesktop.org
> Sent: Tuesday, June 9, 2015 3:45:11 PM
> Subject: Re: [Spice-devel] [PATCH] spice-widget: Do not update display when resize-guest is disabled
> 
> On Thu, 2015-06-04 at 13:23 +0200, Fabiano Fidêncio wrote:
> > Updating the display causes weird behaviors in virt-viewer, like
> > re-resizing to a previous monitor config when, after changing the
> > display resolution (through System > PReferences > Displays). the agent
> > reconnects.
> > It is not perfect yet, because when the agent reconnects the guest
> > resizes to the previous config and switch to the proper one, but this
> > seems more like an agent bug than a spice-gtk one.
> > ---
> >  gtk/spice-widget.c | 4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c
> > index b9c4972..260fda5 100644
> > --- a/gtk/spice-widget.c
> > +++ b/gtk/spice-widget.c
> > @@ -293,10 +293,6 @@ static void update_monitor_area(SpiceDisplay *display)
> >          goto whole;
> >      }
> >  
> > -    if (!d->resize_guest_enable)
> > -        spice_main_update_display(d->main, get_display_id(display),
> > -                                  c->x, c->y, c->width, c->height, FALSE);
> > -
> >      update_area(display, c->x, c->y, c->width, c->height);
> >      g_clear_pointer(&monitors, g_array_unref);
> >      return;
> 
> Ack.

Pushed, thanks!

> 
> Pavel
> 
> 
>