[Spice-devel] [PATCH spice-server v2 1/2] Use image compress constants from spice-protocol

Christophe Fergeau cfergeau at redhat.com
Thu Jun 11 07:44:51 PDT 2015


On Mon, Jun 01, 2015 at 04:48:15PM +0200, Javier Celaya wrote:
> diff --git a/server/spice-server.h b/server/spice-server.h
> index bca0da6..5880ff0 100644
> --- a/server/spice-server.h
> +++ b/server/spice-server.h
> @@ -67,20 +67,9 @@ int spice_server_add_interface(SpiceServer *s,
>                                 SpiceBaseInstance *sin);
>  int spice_server_remove_interface(SpiceBaseInstance *sin);
>  
> -typedef enum {
> -    SPICE_IMAGE_COMPRESS_INVALID  = 0,
> -    SPICE_IMAGE_COMPRESS_OFF      = 1,
> -    SPICE_IMAGE_COMPRESS_AUTO_GLZ = 2,
> -    SPICE_IMAGE_COMPRESS_AUTO_LZ  = 3,
> -    SPICE_IMAGE_COMPRESS_QUIC     = 4,
> -    SPICE_IMAGE_COMPRESS_GLZ      = 5,
> -    SPICE_IMAGE_COMPRESS_LZ       = 6,
> -    SPICE_IMAGE_COMPRESS_LZ4      = 7,
> -} spice_image_compression_t;

Removing spice_image_compression_t from spice-server.h which is a public
header is going to break compilation of applications using it (eg QEMU), this
needs to be replaced with

typedef SpiceImageCompress spice_image_compression_t;

I'll squash that in my local version.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150611/646c09b7/attachment.sig>


More information about the Spice-devel mailing list