[Spice-devel] [PATCH spice-gtk 2/2] configure: Do not force audio by default

[Victor Toso]

Yes, currently behavior makes configure fail if we don't have libpulse
devel packages even if we do have gstreamer!

I also agree that 'auto' could mean no audio here.
Both patches looks okay for me. I've tested locally and works as
expected:

--with-audio=auto : try libpulse, then try gstreamer-1.0; no audio if
both are not available.

On Fri, Jun 12, 2015 at 12:24:04PM +0200, Pavel Grunt wrote:
> Disable audio if no backend is available and configure is used with
> the option '--with-audio=auto'
> ---
>  configure.ac | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 1156856..6af968f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -308,10 +308,14 @@ esac
>  
>  AS_IF([test "x$with_audio" = "xauto"],
>        [AS_IF([test "x$os_win32" = "xyes"],
> -             [with_audio=gstreamer],
> +             [AS_IF([test "x$have_gst" = "xyes"],
> +                    [with_audio=gstreamer],
> +                    [with_audio=no])],
>               [AS_IF([test "x$have_pulse" = "xyes"],
>                      [with_audio=pulse],
> -                    [with_audio=gstreamer])])])
> +                    [AS_IF([test "x$have_gst" = "xyes"],
> +                           [with_audio=gstreamer],
> +                           [with_audio=no])])])])
>  
>  AS_IF([test "x$have_pulse" = "xyes"],
>        [AC_DEFINE([WITH_PULSE], 1, [Have pulseaudio?])],
> -- 
> 2.4.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel