[Spice-devel] [spice-gtk PATCH v2] spice-widget: keypress-delay set by env var

Victor Toso victortoso at redhat.com
Thu Jun 18 06:34:32 PDT 2015


Hey,

On Thu, Jun 18, 2015 at 09:11:08AM -0400, Marc-André Lureau wrote:
> > +            if (env != NULL)
> > +                delay = (guint) g_ascii_strtoull(env, NULL, 10);
> > +
> strtoul is probably fine too (without cast?)

Yeah, I'm always using glib even when not necessary...

> > +            SPICE_DEBUG("keypress-delay is set to %u ms", delay);
> > +            d->keypress_delay = delay;
> > +        }
> >          break;
> >      default:
> >          G_OBJECT_WARN_INVALID_PROPERTY_ID(object, prop_id, pspec);
> > --
> > 2.4.3
> >
>
> otherwise, looks good to me

Thanks, applied the changes and pushed as
1af5b67bcd474aef2aea02f07db3626a25956b2d


More information about the Spice-devel mailing list