[Spice-devel] [PATCH] Add monitors_config escape to Windows QXL display driver.

[Christophe Fergeau]

Not familiar at all with the windows driver code, but this one looks
good. The setting of QXLRam::monitors_config value is quite convoluted,
but seems in line with what the rest of the code does.
SetMonitorsConfig will change if you agree with the suggested changes
for the QXLEscapeMonitorConfig structure.

On Thu, Jun 18, 2015 at 07:14:12PM -0400, sstutsma at redhat.com wrote:
> From: Sandy Stutsman <sstutsma at redhat.com>
> 
> Provides correct monitor locations when specified via the guest
> "Screen Resolution" applet.
> 
> Addresses:https://bugzilla.redhat.com/show_bug.cgi?id=1202419
> ---
> diff --git a/xddm/display/res.c b/xddm/display/res.c
> index bfb3571..3ea1760 100644
> --- a/xddm/display/res.c
> +++ b/xddm/display/res.c
> @@ -2005,7 +2019,7 @@ static BOOL CacheSizeTest(PDev *pdev, SURFOBJ *surf)
>  {
>      BOOL ret = (UINT32)surf->sizlBitmap.cx * surf->sizlBitmap.cy <= pdev->max_bitmap_size;
>      if (!ret) {
> -        DEBUG_PRINT((pdev, 1, "%s: cache size test failed x %d y %d max\n",
> +        DEBUG_PRINT((pdev, 1, "%s: cache size test failed x %d y %d max %d\n",
>                       __FUNCTION__,
>                       surf->sizlBitmap.cx,
>                       surf->sizlBitmap.cy,

This change seems unrelated to the rest of the commit.

> diff --git a/xddm/miniport/qxl.c b/xddm/miniport/qxl.c
> index f5d6b48..4670893 100644
> --- a/xddm/miniport/qxl.c
> +++ b/xddm/miniport/qxl.c
> @@ -1256,12 +1257,14 @@ BOOLEAN StartIO(PVOID dev_extension, PVIDEO_REQUEST_PACKET packet)
>              driver_info->dev_id = dev_ext->rom->id;
>  
>              driver_info->create_non_primary_surfaces = check_non_primary_surfaces_registry_key(dev_ext);
> +
> +            driver_info->monitors_config = &dev_ext->ram_header->monitors_config;
>          }
>          break;
>  
>      case IOCTL_QXL_SET_CUSTOM_DISPLAY: {
>              QXLEscapeSetCustomDisplay *custom_display;
> -            DEBUG_PRINT((dev_ext, 0, "%s: IOCTL_QXL_SET_CUSTOM_DISPLAY\n", __FUNCTION__));
> +            DEBUG_PRINT((dev_ext, 0, "%s: Device %d, IOCTL_QXL_SET_CUSTOM_DISPLAY\n", __FUNCTION__, dev_ext->rom->id));

I would have kept that one separate as well

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150622/48d7d03f/attachment.sig>