[Spice-devel] [spice PATCH] Lock the pixmap cache for the fill_bits function call.

Christophe Fergeau cfergeau at redhat.com
Tue Jun 23 02:20:09 PDT 2015


On Mon, Jun 22, 2015 at 05:46:43PM -0400, Sandy Stutsman wrote:
> Locking the individual calls that access the pixmap cache in fill_bits is
> not adequately thread safe. Often a windows guest with multiple monitors
> will be sending the same image via different threads. Both threads can
> be in fill_bits at the same making changes to the cache for the same
> image. This can result in images being deleted before all the client
> channels are finished with them or with the same image being send multiple
> times.
> 
> Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1194354
> ---
> Replaces the possibly corrupt patch sent out yesterday

This one looks corrupt again, blank space missing at the beginning of
lines. One potential way to avoid these issues would be
https://git.wiki.kernel.org/index.php/MSysGit:UsingSendEmail
https://git-scm.com/docs/git-format-patch#_mua_specific_hints has some
hints for thunderbird as well.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150623/81123136/attachment.sig>


More information about the Spice-devel mailing list