[Spice-devel] [spice-protocol PATCH v2] Add monitors_config escape for qxl-win driver

Christophe Fergeau cfergeau at redhat.com
Tue Jun 23 02:56:00 PDT 2015


On Mon, Jun 22, 2015 at 07:28:54PM -0400, Sandy Stutsman wrote:
> Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
> 
> A monitors_config message needs to be sent from the guest to the client
> when monitors are ordered with the "Set Resolution" applet.
> ---
> I think it is best to keep the Windows driver escape structures together in
> the qxl_windows.h file

Why? We have a pre-existing data structure which is not OS-specific, and
the escape handler converts from this QXLEscapeMonitorConfig to QXLHead,
so why not directly pass a QXLHead? An alternative would be to use
VDAgentMonConfig which nearly matches your new struct, but this one
is used for client -> agent communication, I don't know if this could
get confusing or not.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150623/5a02e837/attachment.sig>


More information about the Spice-devel mailing list