[Spice-devel] [libvirt] [PATCH v2] qemu: Use heads parameter for QXL driver

[Frediano Ziglio]

> 
> On Fri, Jun 12, 2015 at 11:57:31AM +0100, Frediano Ziglio wrote:
> >Allows to specify maximum number of head to QXL driver.
> >
> >Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> >
> >The patch to support the "max_outputs" in Qemu is still not merged but
> >I got agreement on the name of the argument.
> >
> >Actually can be a compatiblity problem as heads in the XML configuration
> >was set by default to '1'.
> 
> Could we avoid that by passing the value to QEMU only if it's greater
> than 1?
> 

And what about if I just want one monitor ? Specify a "one" value ?

> >---
> > src/qemu/qemu_capabilities.c                     | 3 +++
> > src/qemu/qemu_capabilities.h                     | 1 +
> > src/qemu/qemu_command.c                          | 5 +++++
> > tests/qemucapabilitiesdata/caps_1.2.2-1.caps     | 1 +
> > tests/qemucapabilitiesdata/caps_1.2.2-1.replies  | 8 ++++++++
> > tests/qemucapabilitiesdata/caps_1.3.1-1.caps     | 1 +
> > tests/qemucapabilitiesdata/caps_1.3.1-1.replies  | 8 ++++++++
> > tests/qemucapabilitiesdata/caps_1.4.2-1.caps     | 1 +
> > tests/qemucapabilitiesdata/caps_1.4.2-1.replies  | 8 ++++++++
> > tests/qemucapabilitiesdata/caps_1.5.3-1.caps     | 1 +
> > tests/qemucapabilitiesdata/caps_1.5.3-1.replies  | 8 ++++++++
> > tests/qemucapabilitiesdata/caps_1.6.0-1.caps     | 1 +
> > tests/qemucapabilitiesdata/caps_1.6.0-1.replies  | 8 ++++++++
> > tests/qemucapabilitiesdata/caps_1.6.50-1.caps    | 1 +
> > tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 8 ++++++++
> > tests/qemucapabilitiesdata/caps_2.1.1-1.caps     | 1 +
> > tests/qemucapabilitiesdata/caps_2.1.1-1.replies  | 8 ++++++++
> 
> Why do you put it in outputs of all QEMU versions if it's not merged
> yet?
> 

To pass the checks

Frediano