[Spice-devel] [PATCH spice-server] Use desired image compression for the first image

Christophe Fergeau cfergeau at redhat.com
Fri Jun 26 06:45:40 PDT 2015


On Thu, Jun 25, 2015 at 01:28:42PM +0200, Pavel Grunt wrote:
> Hi Christophe,
> 
> On Mon, 2015-06-22 at 14:20 +0200, Christophe Fergeau wrote:
> > Hey,
> > 
> > Seems fine, though it's not clear to me why this would only impact the
> > first image? 
> It has impact on the first image because other images are compressed by
> red_compress_image(). Maybe the mechanism of choosing the compression should be
> the same for both functions (or have just one function for compression ?) - I
> will look into it.

Ah indeed, I was wondering what's up with red_compress_image VS
red_marshall_image (_marshall_image seems to be used a bit more than
first image, but yeah, seldomly used). Feel free to push this, maybe
with a mention of red_compress_image() in the commit log.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150626/bc4ef155/attachment-0001.sig>


More information about the Spice-devel mailing list