[Spice-devel] [PATCH] usbredir: fix redirection of user-accesible device nodes.

Michal Suchanek michal.suchanek at ruk.cuni.cz
Tue Jun 30 10:25:29 PDT 2015


Excerpts from Christophe Fergeau's message of Tue Jun 30 09:30:42 +0200 2015:
> On Mon, Jun 29, 2015 at 06:59:26PM +0200, Michal Suchanek wrote:
> > Excerpts from Christophe Fergeau's message of Mon Jun 29 17:22:23 +0200 2015:
> > > On Mon, Jun 29, 2015 at 05:11:36PM +0200, Michal Suchanek wrote:

> > > 
> > > I'd present the policykit error when the binary is built with policykit
> > > support.
> > 
> > This gives some interesting results. In spicy I tried to attach a device
> > which is already attached through qemu usb redirection. This fails and
> > libusb error 99 (other) is logged, the policykit failure is displayed in
> > the dialog and the device seems to get upset and has to be reset by the
> > guest.
> > 
> > It seems to recover reasonably well but the fact that there was 'other
> > error' rather than the usual 'permission error' is hidden.
> 
> This seems to be a different issue than what you initially described?
> ('trying to redirect an already redirected device' VS 'trying to
> redirect a device the user has raw access to without using polkit').

I was trying to test the patch. Yes, I am aware that I am doing this for
testing, and the fact that the error is somewhat mysterious is result of
the error handling - both in libspice and libusb and/or kernel. Not sure
where that error 99 comes from. Is there some manual where it should be
pointed out that people should look for libusb errors on stderr when usb
redirection fails?

Thanks

Michal


More information about the Spice-devel mailing list