[Spice-devel] [spice-gtk PATCH v2 2/7] audio: spice-audio with get mute and volume

[Victor Toso]

On Mon, Mar 23, 2015 at 09:36:31AM -0400, Marc-André Lureau wrote:
> 
> Hi
> 
> ----- Original Message -----
> > Functions to be implemented by spice-gstaudio and spice-pulse to get the
> > updated volume and mute values for playback and record stream.
> > ---
> >  gtk/spice-audio.h | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/gtk/spice-audio.h b/gtk/spice-audio.h
> > index ebc4946..2c66259 100644
> > --- a/gtk/spice-audio.h
> > +++ b/gtk/spice-audio.h
> > @@ -67,6 +67,10 @@ struct _SpiceAudioClass {
> >  
> >      /*< private >*/
> >      gboolean (*connect_channel)(SpiceAudio *audio, SpiceChannel *channel);
> > +    gboolean (*get_playback_mute)(SpiceAudio *audio);
> > +    guint16* (*get_playback_volume)(SpiceAudio *audio, guint8 *nchannels);
> > +    gboolean (*get_record_mute)(SpiceAudio *audio);
> > +    guint16* (*get_record_volume)(SpiceAudio *audio, guint8 *nchannels);
> >  
> >      gchar _spice_reserved[SPICE_RESERVED_PADDING];
> >  };
> 
> You need to remove 4 pointers from _spice_reserved padding in order to keep the same struct size and not break ABI.

Done. I'll send v3 after discussing the other patches.
Thanks again for the review,