[Spice-devel] [spice-gtk PATCH v2 7/7] channel: playback and record sync volume/mute

[Victor Toso]

Hi,

On Mon, Mar 23, 2015 at 12:40:45PM -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Mon, Mar 23, 2015 at 10:03:10AM -0400, Marc-André Lureau wrote:
> > > Hi
> > > 
> > > ----- Original Message -----
> > > > Hi,
> > > > 
> > > > On Mon, Mar 23, 2015 at 09:47:07AM -0400, Marc-André Lureau wrote:
> > > > > Hi
> > > > > 
> > > > > ----- Original Message -----
> > > > > > As soon as playback-start and record-start are handled, sync
> > > > > > volume/mute
> > > > > > with guest.
> > > > > 
> > > > > It sounds like this may make a glitch whenever audio start (especially
> > > > > because the volume units are not specified and differ between client,
> > > > > guest and hw). Why not sync only when the agent is started?
> > > > 
> > > > The main problem for that is when the channel is not created yet which
> > > > will fail getting the volume/mute values.
> > > 
> > > Why do you need to wait for the channel to be created? I thought all you
> > > need is SpiceAudio.
> > 
> > To get volume from the stream, you need the stream created, no? The
> > volume-sync failed a few times because of that.
> 
> Right, so why not start it to get the volume? I am afraid that we will
> have more volume issues if we start synchronizing whenever playback
> starts.

I agree, it could lead to more issues.
I did not think about starting it before, thanks! Looks like it worked
fine.